I am 3/4 of the way through a divorce but this 'problem' seems to permeate everything in my life. It is this:
Why, no matter how good I've got it (dating a wonderful person, kids are healthy and happy, job is stable, immediate family gets along and is healthy...) do I always find someone or something better that I have?
I'll readily admit that from the outside my life looks wonderful yet I'm always looking for that one better person, situation or thing.
I was like this in my marriage but had myself convinced I was in it for the long haul and there are ups and downs and in the end being faithful and sticking to what I felt was right would pay off. Other half decided a 3 month affair was more important than 11 years of marriage but that is a different 'session.'
I'm adult child of an alcoholic if that matters and was raised Catholic but have no interest in it right now.
If your honest efforts as a child were sidelined consistently by your family that may be one reason. You were never given the chance to see things through and to wear the laurels and stand on the winner's box holding the trophy high and be proud of your accomplishments (and in my opinion being accomplished is a gift not just to yourself but to those around you and society at large...it is your unique contribution that should be celebrated, has nothing to do with ego, but honest celebration of something good and wholesome...) For a child of an alcoholic this just doesn't happen, so those neural pathways and the belief system doesn't form. So, celebrate what you do even if it's a small thing. In fact, it's the small things that do matter, and fill up that hole inside you. Parents who are neglectful emotionally dismiss the small things, it's so hurtful. Even more than being beaten or not fed, is ignoring a child's soul. So you have to do this for yourself, now that you're an adult, take care of your kid, the one inside you! A good way to do this is to hang out with kids. lol. And nurture them and give the same to yourself.
Another thing that's a biological reason is being addicted to the adrenaline cycle. Uncertainty and hyper-alertness in childhood develops the adrenal system to always need to respond to environmental stress. So an environment that's calm, peaceful, rewarding...makes the stress build up and build up...leaving things unfinished or unconsciously creating a situation of stress feeds that need for the adrenal system. Adrenaline is addictive, just like speed. You need to completely sedate this system for a long period of time, to train your adrenal system and also your brain to accept the peaceful calm situation as normal, and toxic people and stressful situations as not normal. However this does not mean boring, you can feed the monkey on your back some peanuts, go to an amusement park and ride the extreme rides, take on a project you enjoy but has a risk of failure if you don't work hard, exercise (dance, rock climb...) take risks with your sense of style, ride your bike without hands, go snowboarding or whatever.
Therapy does help but the bottom line is that talking to someone and understanding the root of the problem isn't going to solve it. The issue is underlying biological addiction and needs to be treated as such. Seriously.
Things like really cutting down on sugar, avoiding overloading your system with foods that cause it to overwork (high fat and high sugar foods), lack of sleep, caffeine, stress due to ignoring deadlines and other procrastination...all of those have to go if you are serious about solving your problem.
You also do need to take on selected projects you know you will enjoy, see them through, and celebrate their successes (even though imperfect...everything in life is imperfect, lol.)